Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7D806200CC9 for ; Mon, 17 Jul 2017 23:19:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7BFF7165CC5; Mon, 17 Jul 2017 21:19:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C2C49165CC3 for ; Mon, 17 Jul 2017 23:19:03 +0200 (CEST) Received: (qmail 86568 invoked by uid 500); 17 Jul 2017 21:19:02 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 86557 invoked by uid 99); 17 Jul 2017 21:19:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jul 2017 21:19:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6EB731A08DC for ; Mon, 17 Jul 2017 21:19:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id jMyxh-tj7oNH for ; Mon, 17 Jul 2017 21:19:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 091BB5F6C3 for ; Mon, 17 Jul 2017 21:19:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 520B7E0069 for ; Mon, 17 Jul 2017 21:19:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 104942475C for ; Mon, 17 Jul 2017 21:19:00 +0000 (UTC) Date: Mon, 17 Jul 2017 21:19:00 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-12138) Remove redundant 'public' modifiers from BlockCollection MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 17 Jul 2017 21:19:04 -0000 [ https://issues.apache.org/jira/browse/HDFS-12138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090583#comment-16090583 ] Hudson commented on HDFS-12138: ------------------------------- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12021 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/12021/]) HDFS-12138. Remove redundant 'public' modifiers from BlockCollection. (szetszwo: rev ed27f2b2cc6093865367b98a100dcd42b2c6b89d) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockCollection.java > Remove redundant 'public' modifiers from BlockCollection > -------------------------------------------------------- > > Key: HDFS-12138 > URL: https://issues.apache.org/jira/browse/HDFS-12138 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode > Reporter: Chen Liang > Assignee: Chen Liang > Priority: Trivial > Fix For: 2.9.0, 3.0.0-alpha4 > > Attachments: HDFS-12138.001.patch > > > The 'public' modifier of the methods in {{BlockCollection}} are redundant, since this is a public interface. Running checkstyle against also complains this. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org