hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Manoj Govindassamy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12217) HDFS snapshots doesn't capture all open files when one of the open files is deleted
Date Sat, 29 Jul 2017 08:50:03 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106076#comment-16106076
] 

Manoj Govindassamy commented on HDFS-12217:
-------------------------------------------

* {{LeaseManager#getINodeWithLeases}} already logs the warning message with full exception
and stack trace.
* The caller wraps the message into a {{SnapshotException}} for the upper layer usage.
* SnapshotException() doesn't accept the throwable argument. We need to change SnapshotException()
and all the users in the all the snapshot commands to have an uniform behavior of returning
the throwable in the RPC call. Will file a new jira for this.
[~yzhangal], are you ok with this ?

> HDFS snapshots doesn't capture all open files when one of the open files is deleted
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-12217
>                 URL: https://issues.apache.org/jira/browse/HDFS-12217
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Manoj Govindassamy
>            Assignee: Manoj Govindassamy
>         Attachments: HDFS-12217.01.patch, HDFS-12217.02.patch, HDFS-12217.03.patch
>
>
> With the fix for HDFS-11402, HDFS Snapshots can additionally capture all the open files.
Just like all other files, these open files in the snapshots will remain immutable. But, sometimes
it is found that snapshots fail to capture all the open files in the system.
> Under the following conditions, LeaseManager will fail to find INode corresponding to
an active lease 
> * a file is opened for writing (LeaseManager allots a lease), and
> * the same file is deleted while it is still open for writing and having active lease,
and
> * the same file is not referenced in any other Snapshots/Trash
> {{INode[] LeaseManager#getINodesWithLease()}} can thus return null for few leases there
by causing the caller to trip over and not return all the open files needed by the snapshot
manager.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message