hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rakesh R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12146) [SPS] : Fix TestStoragePolicySatisfierWithStripedFile#testSPSWhenFileHasLowRedundancyBlocks
Date Mon, 17 Jul 2017 03:28:01 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089263#comment-16089263
] 

Rakesh R commented on HDFS-12146:
---------------------------------

Thank you  [~surendrasingh]. Do you mind correcting {{TestStoragePolicySatisfier#testSPSWhenFileHasLowRedundancyBlocks}}
test as well?
{code}
      cluster.restartNameNodes();
      cluster.restartDataNode(list.get(0), true);
      cluster.restartDataNode(list.get(1), true);
      cluster.waitActive();
      fs.satisfyStoragePolicy(filePath);
      Thread.sleep(3000 * 6);
      cluster.restartDataNode(list.get(2), true);
{code}

Also, I noticed {{Thread.sleep(3000 * 6);}} in these two {{LowRedundancy}} test cases. Do
you think to replace this constant sleep time with the following way or a better logic than
this?
{code}
      fs.satisfyStoragePolicy(filePath);
      DFSTestUtil.waitExpectedStorageType(filePath.toString(),
          StorageType.ARCHIVE, 2, 30000, cluster.getFileSystem());
      cluster.restartDataNode(list.get(2), false);
      DFSTestUtil.waitExpectedStorageType(filePath.toString(),
          StorageType.ARCHIVE, 3, 30000, cluster.getFileSystem());
{code}

> [SPS] : Fix TestStoragePolicySatisfierWithStripedFile#testSPSWhenFileHasLowRedundancyBlocks
> -------------------------------------------------------------------------------------------
>
>                 Key: HDFS-12146
>                 URL: https://issues.apache.org/jira/browse/HDFS-12146
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Surendra Singh Lilhore
>            Assignee: Surendra Singh Lilhore
>         Attachments: HDFS-12146-HDFS-10285.001.patch
>
>
> TestStoragePolicySatisfierWithStripedFile#testSPSWhenFileHasLowRedundancyBlocks failed
in many build with port bind exception. I feel we no need to restart datanodes on same port,
just we checking the block redundancy scenario.. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message