hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Krogen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics
Date Fri, 28 Jul 2017 18:55:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105500#comment-16105500
] 

Erik Krogen commented on HDFS-12131:
------------------------------------

Ah, nice! Looks like you already got the reviews you needed there while I was trying to wrap
my head around the historical discussion in HDFS-10999

Cool, I'm with you on matching up these new ones rather than continuing a questionable practice.
Do we have precedence for deprecating metrics? Given that there is already StaleDataNodes
in FSNamesystem and NumStaleDataNodes in FSNamesystemState, I don't really like the idea of
having a _third_ NumStaleDataNodes in FSNamesystem. But if that's the only way for us to move
towards uniformity here, I'm all for it.

For now I've attached a v003 patch which adds in the Num prefix for the new metrics, and also
adds in the other 6 metrics I mentioned in my first comment. I haven't touched StaleDataNodes
yet.

> Add some of the FSNamesystem JMX values as metrics
> --------------------------------------------------
>
>                 Key: HDFS-12131
>                 URL: https://issues.apache.org/jira/browse/HDFS-12131
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs, namenode
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>            Priority: Minor
>         Attachments: HDFS-12131.000.patch, HDFS-12131.001.patch, HDFS-12131.002.patch,
HDFS-12131.002.patch
>
>
> A number of useful numbers are emitted via the FSNamesystem JMX, but not through the
metrics system. These would be useful to be able to track over time, e.g. to alert on via
standard metrics systems or to view trends and rate changes:
> * NumLiveDataNodes
> * NumDeadDataNodes
> * NumDecomLiveDataNodes
> * NumDecomDeadDataNodes
> * NumDecommissioningDataNodes
> * NumStaleStorages
> This is a simple change that just requires annotating the JMX methods with {{@Metric}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message