hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Krogen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics
Date Thu, 27 Jul 2017 21:52:02 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103972#comment-16103972
] 

Erik Krogen commented on HDFS-12131:
------------------------------------

Hey [~andrew.wang], thanks for looking. Here I followed the example of {{StaleDataNodes}}
since that was the most closely related one, but I agree with you that having the metric name
match the MBean name makes more sense. There are a number of metrics in FSNamesystem that
don't match the MBean though, even besides the Num prefix: LockQueueLength v FsLockQueueLength,
all of the {{ReplicatedBlocksMBean}} ones, and all of the {{ECBlockGroupsStatsMBean}} ones.


I don't really like that {{StaleDataNodes}} will be an outlier compared to the other XxxDataNodes
metrics if I put the Num prefix in this patch, but otherwise I'm in support of it. If you'd
prefer I put back in the Num prefix I'm fine with it.

> Add some of the FSNamesystem JMX values as metrics
> --------------------------------------------------
>
>                 Key: HDFS-12131
>                 URL: https://issues.apache.org/jira/browse/HDFS-12131
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs, namenode
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>            Priority: Minor
>         Attachments: HDFS-12131.000.patch, HDFS-12131.001.patch, HDFS-12131.002.patch,
HDFS-12131.002.patch
>
>
> A number of useful numbers are emitted via the FSNamesystem JMX, but not through the
metrics system. These would be useful to be able to track over time, e.g. to alert on via
standard metrics systems or to view trends and rate changes:
> * NumLiveDataNodes
> * NumDeadDataNodes
> * NumDecomLiveDataNodes
> * NumDecomDeadDataNodes
> * NumDecommissioningDataNodes
> * NumStaleStorages
> This is a simple change that just requires annotating the JMX methods with {{@Metric}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message