hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics
Date Wed, 26 Jul 2017 23:47:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102480#comment-16102480

Andrew Wang commented on HDFS-12131:

I don't see a downside to exposing these as metrics, thanks for doing this Erik!

One question about the patch, I notice that some of the other metrics in FSNamesystem keep
the "Num" prefix:
NumActiveClients, NumFilesUnderConstruction, NumEncryptionZones. Some do not: Snapshots, SnapshottableDirectories.

Do you have an opinion on which is better? I think it'd be simpler if the metric name lined
up with the MBean name. We could consider cleaning this up for the future too, via deprecation
and later removal.

> Add some of the FSNamesystem JMX values as metrics
> --------------------------------------------------
>                 Key: HDFS-12131
>                 URL: https://issues.apache.org/jira/browse/HDFS-12131
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs, namenode
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>            Priority: Minor
>         Attachments: HDFS-12131.000.patch, HDFS-12131.001.patch, HDFS-12131.002.patch,
> A number of useful numbers are emitted via the FSNamesystem JMX, but not through the
metrics system. These would be useful to be able to track over time, e.g. to alert on via
standard metrics systems or to view trends and rate changes:
> * NumLiveDataNodes
> * NumDeadDataNodes
> * NumDecomLiveDataNodes
> * NumDecomDeadDataNodes
> * NumDecommissioningDataNodes
> * NumStaleStorages
> This is a simple change that just requires annotating the JMX methods with {{@Metric}}.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message