hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Weiwei Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12127) Ozone: Ozone shell: Add more testing for key shell commands
Date Thu, 20 Jul 2017 14:39:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094774#comment-16094774
] 

Weiwei Yang commented on HDFS-12127:
------------------------------------

Hi [~linyiqun]

Thanks a lot to add the test case and fix those bugs!  The patch looks really good.This helps
a lot.
Just one minor comment to v2 patch, might be a bit picky :p

*KeyManagerImpl*

Line 112 to 116: can we change it to

{code}
try { 
  ...
}  catch (KSMException e) {
  throw e;
} catch (IOException e) {
  ...
}
{code}

Thanks a lot!

> Ozone: Ozone shell: Add more testing for key shell commands
> -----------------------------------------------------------
>
>                 Key: HDFS-12127
>                 URL: https://issues.apache.org/jira/browse/HDFS-12127
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone, tools
>    Affects Versions: HDFS-7240
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>         Attachments: HDFS-12127-HDFS-7240.001.patch, HDFS-12127-HDFS-7240.002.patch
>
>
> Adding more unit tests for ozone key commands, similar to HDFS-12118.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message