hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chen Liang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12118) Ozone: Ozone shell: Add more testing for volume shell commands
Date Thu, 13 Jul 2017 18:10:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086131#comment-16086131
] 

Chen Liang commented on HDFS-12118:
-----------------------------------

Thanks [~linyiqun] for the update and the reply!

Why it should be [vol-0, vol-10] though? Seems to me that [vol0, vol2] is actually correct
because there are indeed the first two volumes being created and is consistent with the order,
right? Nonetheless, more importantly, in fact, I found my previous comment somewhat misleading,
sorry about that... The whole point I was trying to make about the checking, was that, when
we list, say 5 volumes for test-user-a, we should make sure that:
1. the 5 volumes are among [vol0, vol2, vol4,...vol18], i.e. indeed the volumes belonging
to test-user-a.
2. the 5 volumes are different, i.e. we don't mistakenly list duplicates.
As long as 1 and 2 are met, exactly which 5 volumes got returned shouldn't matter. Because
I believe 1 & 2 are what list volume API promises, the order of how it maintain the volumes
is not part of the syntax. So the check could be just writing and calling a method that walk
through the returned volume list, making sure: 1. they all in a candidate set, e.g., vol0,
vol2,...vol18; and 2. no duplicates in the list. Also, apparently if test-user-a has no more
than 5 volumes in total, they should all be returned.

> Ozone: Ozone shell: Add more testing for volume shell commands
> --------------------------------------------------------------
>
>                 Key: HDFS-12118
>                 URL: https://issues.apache.org/jira/browse/HDFS-12118
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone, tools
>    Affects Versions: HDFS-7240
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>         Attachments: HDFS-12118-HDFS-7240.001.patch, HDFS-12118-HDFS-7240.002.patch,
HDFS-12118-HDFS-7240.003.patch
>
>
> Currently there are missing enough testings to cover all the ozone command. Now we have
to test this in a manual way to see if commands run okay as expected. There will be lots of
test cases we should add for all the volume, bucket and key commands. In order to easy reviewed,
I'd like to separate this work to three subtasks. This JIRA is a good start for implementing
for volume commands.
> Plan to add the unit test to test following command and its available options:
> * infoVolume
> * updateVolume
> * listVolume
> * createVolume



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message