hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Weiwei Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12115) Ozone: SCM: Add queryNode RPC Call
Date Tue, 18 Jul 2017 04:03:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091068#comment-16091068
] 

Weiwei Yang commented on HDFS-12115:
------------------------------------

Hi [~anu]

Thanks for the updates, I have comments to the v5 patch,

*InProgressPool.java*

NIT, line 203, extra space between NodeState and getNodeState

*MockNodeManager.java*

line 161-173, it seems this can be replaced by {{getNodes(nodestate).size()}}, but we need
to make sure getNodes won't return us a null, maybe a empty list?

*Ozone.proto*

Add a placeholder for {{DECOMMISSIONING}} state?

*SCMNodeManager.java*

line 413-435, like you mentioned earlier, a node may have more than 1 state, e.g both HEALTHY
and RAFT_MEMBER. But here getNodeState will only return single state, should this return an
array of NodeState?

line 491: instead of creating a new list, this can be done in java8 style
{{return currentSet.stream().collect(Collectors.toList());}}

Hope this helps, thanks

> Ozone: SCM: Add queryNode RPC Call
> ----------------------------------
>
>                 Key: HDFS-12115
>                 URL: https://issues.apache.org/jira/browse/HDFS-12115
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-12115-HDFS-7240.001.patch, HDFS-12115-HDFS-7240.002.patch,
HDFS-12115-HDFS-7240.003.patch, HDFS-12115-HDFS-7240.004.patch, HDFS-12115-HDFS-7240.005.patch
>
>
> Add queryNode RPC to Storage container location protocol. This allows applications like
SCM CLI to get the list of nodes in various states, like Healthy, live or Dead.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message