hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nandakumar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12083) Ozone: KSM: previous key has to be excluded from result in listVolumes, listBuckets and listKeys
Date Thu, 13 Jul 2017 06:34:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085258#comment-16085258
] 

Nandakumar commented on HDFS-12083:
-----------------------------------

Thanks [~linyiqun] for the review.

In case of invalid start key (startBucket in this case), {{LevelDBStore#getRangeKVs}} will
throw IOException.  {{rangeResult.remove(0)}} will never get called in that case.

>From {{LevelDBStore#getRangeKVs}}

{quote}
 * If the startKey is specified and found in levelDB, this key and the keys
 * after this key will be included in the result. If the startKey is null
 * all entries will be included as long as other conditions are satisfied.
 * If the given startKey doesn't exist, an IOException will be thrown.
{quote}
{code}
if (db.get(startKey) == null) {
  throw new IOException("Invalid start key, not found in current db.");
}
{code}

> Ozone: KSM: previous key has to be excluded from result in listVolumes, listBuckets and
listKeys
> ------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-12083
>                 URL: https://issues.apache.org/jira/browse/HDFS-12083
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Nandakumar
>            Assignee: Nandakumar
>            Priority: Critical
>         Attachments: HDFS-12083-HDFS-7240.000.patch, HDFS-12083-HDFS-7240.001.patch
>
>
> When previous key is set as part of list calls [listVolume, listBuckets & listKeys],
the result includes previous key, there is no need to have this in the result. 
> Since previous key is present as part of result, we will never receive an empty list
in the subsequent list calls, this makes it difficult to have a exit criteria where we want
to get all the values using multiple list calls (with previous-key set).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message