hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12078) Add time unit to the description of property dfs.namenode.stale.datanode.interval in hdfs-default.xml
Date Tue, 04 Jul 2017 05:49:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073136#comment-16073136
] 

Akira Ajisaka commented on HDFS-12078:
--------------------------------------

LGTM, +1.

> Add time unit to the description of property dfs.namenode.stale.datanode.interval in
hdfs-default.xml
> -----------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-12078
>                 URL: https://issues.apache.org/jira/browse/HDFS-12078
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>            Priority: Trivial
>         Attachments: HDFS-12078.001.patch
>
>
> The description of property {{dfs.namenode.stale.datanode.interva}} in hdfs-default.xml
doesn't mention about the time unit, we should add that to avoid confusing users.
> I have reviewed all properties in hdfs-default.xml, this is the only one property causes
such confusion, user should be able to easily figure out the appropriate time unit for properties
by either
> * Specified by property name, e.g dfs.namenode.full.block.report.lease.length.ms
> * Specified by property value with time unit suffix, e.g dfs.blockreport.initialDelay=0s
> * Explained by description of the property, e.g dfs.namenode.safemode.extension=3000,
description: Determines extension of safe mode in milliseconds ...
> change to the property name and value will be an incompatible change, to minimize the
impact, propose to simply add the time unit in the description (3rd approach). And this should
be only one property needs the fix in hdfs-default.xml.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message