hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Zhuge (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-12052) Set SWEBHDFS delegation token kind when ssl is enabled in HttpFS
Date Mon, 10 Jul 2017 17:59:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080738#comment-16080738
] 

John Zhuge edited comment on HDFS-12052 at 7/10/17 5:58 PM:
------------------------------------------------------------

Thank you [~3opan] for the excellent find and the patch submitted.

Could you please revert the unrelated format changes? They add noise to the code review and
will complicate backport. Please read https://wiki.apache.org/hadoop/HowToContribute regarding
"reformat" :
{noformat}
Please do not:

* reformat code unrelated to the bug being fixed: formatting changes should be separate patches/commits.
{noformat}

Please note the reformat might been done automatically by your IDE.


was (Author: jzhuge):
Thank you [~3opan] for the excellent find and the patch submitted.

Could you please revert the unrelated format changes? They add noise to the code review and
will complicate backport. Please read https://wiki.apache.org/hadoop/HowToContribute regard
"reformat" :
{noformat}
Please do not:

* reformat code unrelated to the bug being fixed: formatting changes should be separate patches/commits.
{noformat}

Please note the reformat might been done automatically by your IDE.

> Set SWEBHDFS delegation token kind when ssl is enabled in HttpFS
> ----------------------------------------------------------------
>
>                 Key: HDFS-12052
>                 URL: https://issues.apache.org/jira/browse/HDFS-12052
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: httpfs, webhdfs
>    Affects Versions: 2.7.3, 3.0.0-alpha3
>            Reporter: Zoran Dimitrijevic
>            Assignee: Zoran Dimitrijevic
>         Attachments: HDFS-12052.00.patch, HDFS-12052.01.patch, HDFS-12052.02.patch, HDFS-12052.03.patch,
HDFS-12052.04.patch
>
>
> When httpfs runs with httpfs.ssl.enabled it should return SWEBHDFS delegation tokens.

> Currently, httpfs returns WEBHDFS delegation "kind" for tokens regardless of whether
ssl is enabled or not. If clients directly connect to renew tokens (for example, hdfs dfs)
all works because httpfs doesn't check whether token kind is for swebhdfs or webhdfs. However,
this breaks when yarn rm needs to renew the token for the job (for example, when running hadoop
distcp). Since DT kind is WEBHDFS, rm tries to establish non-ssl connection to httpfs and
fails.
> I've tested a simple patch which I'll upload to this jira, and it fixes this issue (hadoop
distcp works).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message