hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Weiwei Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
Date Sat, 01 Jul 2017 02:53:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070965#comment-16070965
] 

Weiwei Yang commented on HDFS-12030:
------------------------------------

Hi [~linyiqun]

Thanks for the updates! It seems you added a {{key-info}} query parameter, that is still against
the design. Please take a look at the [design doc|https://issues.apache.org/jira/secure/attachment/12799549/ozone_user_v0.pdf],
page 38, info key. The rest api schema is

{code}
GET /{volume}/{bucket}/{key}?info=key
{code}

and also we should make sure get key API schema is

{code}
GET /{volume}/{bucket}/{key}
{code}

So I guess we still need following changes

*Keys.java*

Remove default value for query parameter {{info}}, so in the handler we can handle this like

* if {{info}} is null -> call getkey
* if {{info}} is key -> call getKeyInfo
* if {{info}} is some other strings -> invalid query parameter

Please remove non-used import.

*OzoneBucket.java*

line 528, 529 when sets up the http request to get key info, instead of using {{info=key-info}},
change to use {{info=key}}.

*KeyHandler.java*

Instead of using a switch statement to check info value {{key}} or {{key-info}}, lets check
{{null}} (query header not set) or {{info}}.

Please fix java doc for {{#getKey}}, also some arguments seem to be missing or mismatch in
java doc.

Please let me know if this makes sense, thank you!

> Ozone: CLI: support infoKey command
> -----------------------------------
>
>                 Key: HDFS-12030
>                 URL: https://issues.apache.org/jira/browse/HDFS-12030
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Xiaoyu Yao
>            Assignee: Yiqun Lin
>         Attachments: HDFS-12030-HDFS-7240.001.patch, HDFS-12030-HDFS-7240.002.patch,
HDFS-12030-HDFS-7240.003.patch, HDFS-12030-HDFS-7240.004.patch
>
>
> {code}
> HW11717:ozone xyao$ hdfs oz -infoKey http://localhost:9864/vol-2/bucket-1/key-1 -user
xyao 
> Command Failed : {"httpCode":0,"shortMessage":"Not supported yet","resource":null,"message":"Not
supported yet","requestID":null,"hostName":null}
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message