hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinayakumar B (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-11898) DFSClient#isHedgedReadsEnabled() should be per client flag
Date Mon, 03 Jul 2017 12:04:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038195#comment-16038195
] 

Vinayakumar B edited comment on HDFS-11898 at 7/3/17 12:03 PM:
---------------------------------------------------------------

bq. I don't think new variable hedgedReadEnabled is needed. You should reset HEDGED_READ_THREAD_POOL
as I commented above.
Yes, it will not be required if we come to conclusion about non-static threadpool. Otherwise
its required, to indicate whether to use that threadpool or not.
bq. Not sure you addressed any of my comments in the last patch.
All of the above comments (except unused variable, of-course its not from the patch) are related
to non-static threadpool. unless we decide to use non-static threadpool, all those cannot
be addressed.
bq. I think HDFS-11900 should be combined with this issue.
I am also okay for combining. Its just that, if we can have a flag till the conclusion about
non-static/static threadpool is clear, hedged and non-hedged clients can co-exist.


was (Author: vinayrpet):
bq, I don't think new variable hedgedReadEnabled is needed. You should reset HEDGED_READ_THREAD_POOL
as I commented above.
Yes, it will not be required if we come to conclusion about non-static threadpool. Otherwise
its required, to indicate whether to use that threadpool or not.
bq. Not sure you addressed any of my comments in the last patch.
All of the above comments (except unused variable, of-course its not from the patch) are related
to non-static threadpool. unless we decide to use non-static threadpool, all those cannot
be addressed.
bq. I think HDFS-11900 should be combined with this issue.
I am also okay for combining. Its just that, if we can have a flag till the conclusion about
non-static/static threadpool is clear, hedged and non-hedged clients can co-exist.

> DFSClient#isHedgedReadsEnabled() should be per client flag 
> -----------------------------------------------------------
>
>                 Key: HDFS-11898
>                 URL: https://issues.apache.org/jira/browse/HDFS-11898
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HDFS-11898-01.patch, HDFS-11898-02.patch
>
>
> DFSClient#isHedgedReadsEnabled() returns value based on static {{HEDGED_READ_THREAD_POOL}}.

> Hence if any of the client initialized this in JVM, all remaining client reads will be
going through hedged read itself.
> This flag should be per client value.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message