hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10874) libhdfs++: Public API headers should not depend on internal implementation
Date Wed, 19 Jul 2017 14:53:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093208#comment-16093208
] 

Stephen commented on HDFS-10874:
--------------------------------

Looks good. A couple of minor suggestions:
* Try to avoid using pair<> for "first class types", such as in URI::query (also the
plural, "queries", is more fitting) . It is easier to understand the meaning of "key" and
"value" than "first" and "second". This is primarily a comment on the existing API but the
changes in this JIRA make it more prominent.
* parse_uri_into_optional was added to make tests backward compatible with previous API. Perhaps
better to change the tests to use the updated API.

> libhdfs++: Public API headers should not depend on internal implementation
> --------------------------------------------------------------------------
>
>                 Key: HDFS-10874
>                 URL: https://issues.apache.org/jira/browse/HDFS-10874
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: James Clampffer
>            Assignee: James Clampffer
>         Attachments: HDFS-10874.HDFS-8707.000.patch, HDFS-10874.HDFS-8707.001.patch
>
>
> Public headers need to do some combination of the following: stop including parts of
the implementation, forward declare bits of the implementation where absolutely needed, or
pull the implementation into include/hdfspp if it's inseparable.
> Example:
> If you want to use the C++ API and only stick include/hdfspp in the include path you'll
get an error when you include include/hdfspp/options.h because that goes and includes common/uri.h.
> Related to the work described in HDFS-10787.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message