Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 28 Jun 2017 14:09:00 +0000 (UTC)
From: "Mukul Kumar Singh (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13083064.1498639236000.124533.1498658940062@Atlassian.JIRA>
In-Reply-To: <JIRA.13083064.1498639236000@Atlassian.JIRA>
References: <JIRA.13083064.1498639236000@Atlassian.JIRA> <JIRA.13083064.1498639236933@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HDFS-12053) Ozone: ozone server should create
 missing metadata directory if it has permission to
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 28 Jun 2017 14:09:04 -0000


    [ https://issues.apache.org/jira/browse/HDFS-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066525#comment-16066525 ] 

Mukul Kumar Singh commented on HDFS-12053:
------------------------------------------

Hi [~cheersyang], The patch looks good, couple of comments though

1) Both line 132 and 134 can be combined in one statement
2) Also I feel that lines 147-152 can also be removed as part of this change by adding extra condition to line 132.

> Ozone: ozone server should create missing metadata directory if it has permission to
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-12053
>                 URL: https://issues.apache.org/jira/browse/HDFS-12053
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>         Attachments: HDFS-12053-HDFS-7240.001.patch
>
>
> Datanode state machine right now simple fails if container metadata directory is missing, it is better to create the directory if it has permission to. This is extremely useful at a fresh setup, usually we set {{ozone.container.metadata.dirs}} to be under same parent of {{dfs.datanode.data.dir}}. E.g
> * /hadoop/hdfs/data
> * /hadoop/hdfs/scm
> if I don't pre-setup /hadoop/hdfs/scm/repository, ozone could not be started.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org