Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 15 Jun 2017 03:02:00 +0000 (UTC)
From: "James Clampffer (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13079288.1497294562000.21433.1497495720085@Atlassian.JIRA>
In-Reply-To: <JIRA.13079288.1497294562000@Atlassian.JIRA>
References: <JIRA.13079288.1497294562000@Atlassian.JIRA> <JIRA.13079288.1497294562047@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HDFS-11971) libhdfs++: A few portability issues
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 15 Jun 2017 03:02:05 -0000


    [ https://issues.apache.org/jira/browse/HDFS-11971?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1604=
9943#comment-16049943 ]=20

James Clampffer commented on HDFS-11971:
----------------------------------------

Thanks for the fixes [~anatoli.shein]!.  Linking the static library in the =
tools is definitely an improvement.

{code}
29=09# Several examples in different languages need to produce executables =
with=09=09
30=09# same names. To allow executables with same names we keep their CMake=
=09=09
31=09# names different, but specify their executable names as follows:=09=
=09
32=09set_target_properties( gendirs_cc=09=09
33=09    PROPERTIES=09=09
34=09    OUTPUT_NAME "gendirs"=09=09
35=09)
{code}

Did set_target_properties cause issues for your build?

> libhdfs++: A few portability issues
> -----------------------------------
>
>                 Key: HDFS-11971
>                 URL: https://issues.apache.org/jira/browse/HDFS-11971
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Anatoli Shein
>            Assignee: Anatoli Shein
>         Attachments: HDFS-11971.HDFS-8707.000.patch, HDFS-11971.HDFS-8707=
.001.patch, HDFS-11971.HDFS-8707.002.patch
>
>
> I recently encountered a few portability issues with libhdfs++ while tryi=
ng to build it as a stand alone project (and also as part of another Apache=
 project).
> 1. Method fixCase in configuration.h file produces a warning "conversion =
to =E2=80=98char=E2=80=99 from =E2=80=98int=E2=80=99 may alter its value [-=
Werror=3Dconversion]" which does not allow libhdfs++ to be compiled as part=
 of the codebase that treats such warnings as errors (can be fixed with a s=
imple cast).
> 2. In CMakeLists.txt file (in libhdfspp directory) we do find_package(Thr=
eads) however we do not link it to the targets (e.g. hdfspp_static), which =
causes the build to fail with pthread errors. After the Threads package is =
found we need to link it using ${CMAKE_THREAD_LIBS_INIT}.
> 3. All the tools and examples fail to build as part of a standalone libhd=
fs++ because they are missing multiple libraries such as protobuf, ssl, pth=
read, etc. This happens because we link them to a shared library hdfspp ins=
tead of hdfspp_static library. We should either link all the tools and exam=
ples to hdfspp_static library or explicitly add linking to all missing libr=
aries for each tool/example.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org