Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D972C200CC1 for ; Mon, 5 Jun 2017 05:34:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D84BB160BE0; Mon, 5 Jun 2017 03:34:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2D813160BE3 for ; Mon, 5 Jun 2017 05:34:08 +0200 (CEST) Received: (qmail 34345 invoked by uid 500); 5 Jun 2017 03:34:07 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 34321 invoked by uid 99); 5 Jun 2017 03:34:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Jun 2017 03:34:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 90589C0254 for ; Mon, 5 Jun 2017 03:34:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ypM2SdYz1gZt for ; Mon, 5 Jun 2017 03:34:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 25DAC5F5A2 for ; Mon, 5 Jun 2017 03:34:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 582EAE00D4 for ; Mon, 5 Jun 2017 03:34:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 11D4420DF1 for ; Mon, 5 Jun 2017 03:34:04 +0000 (UTC) Date: Mon, 5 Jun 2017 03:34:04 +0000 (UTC) From: "LiXin Ge (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-11925) HDFS oiv:Normalize the verification of input parameter MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 05 Jun 2017 03:34:09 -0000 [ https://issues.apache.org/jira/browse/HDFS-11925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LiXin Ge updated HDFS-11925: ---------------------------- Attachment: HDFS-11925.patch > HDFS oiv:Normalize the verification of input parameter > ------------------------------------------------------ > > Key: HDFS-11925 > URL: https://issues.apache.org/jira/browse/HDFS-11925 > Project: Hadoop HDFS > Issue Type: Bug > Components: tools > Affects Versions: 3.0.0-alpha3 > Reporter: LiXin Ge > Assignee: LiXin Ge > Fix For: 3.0.0-alpha4 > > Attachments: HDFS-11925.patch > > > At present, hdfs oiv tool lacks in verification of input parameter.people can type in irrelevant option like: > bq. ./hdfs oiv -i fsimage_0000000000000000000 -p XML -step 1024 > or type in option with wrong format which he think come into effec but actually not: > bq. ./hdfs oiv -i fsimage_0000000000000000000 -p FileDistribution maxSize 4096 step 512 format > or some meaningless word which can also get through: > bq. ./hdfs oiv -i fsimage_0000000000000000000 -p XML Hello Han Meimei > We'd better not let these cases go unchecked. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org