Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B1208200CC5 for ; Mon, 26 Jun 2017 12:28:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AF92D160BDE; Mon, 26 Jun 2017 10:28:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0AFF1160BF5 for ; Mon, 26 Jun 2017 12:28:03 +0200 (CEST) Received: (qmail 1641 invoked by uid 500); 26 Jun 2017 10:28:03 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 1627 invoked by uid 99); 26 Jun 2017 10:28:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Jun 2017 10:28:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9106EC061B for ; Mon, 26 Jun 2017 10:28:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id QdRTE0hxjn5d for ; Mon, 26 Jun 2017 10:28:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 7E8B95F6D2 for ; Mon, 26 Jun 2017 10:28:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DC645E0D96 for ; Mon, 26 Jun 2017 10:28:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3FEFD240CC for ; Mon, 26 Jun 2017 10:28:00 +0000 (UTC) Date: Mon, 26 Jun 2017 10:28:00 +0000 (UTC) From: "Weiwei Yang (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-11773) Ozone: KSM : add listVolumes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 26 Jun 2017 10:28:04 -0000 [ https://issues.apache.org/jira/browse/HDFS-11773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062886#comment-16062886 ] Weiwei Yang commented on HDFS-11773: ------------------------------------ Patch uploaded, v1 patch implemented listVolumes in KSM. Unit tests can be found in {{TestKeySpaceManager#testListVolumes}} and real cluster tests can be found in attachment [^listVolume_tests.log], please help to review. Note, this patch doesn't fix following issues # ozone CLI listVolume command doesn't support prefix, startKey and maxKey arguments # the permission check module right now only makes sure only root user can scan all volumes. But it doesn't check if userA can listVolumes owned by userB # listVolume result has some missing fields, because those info isn't updated to KSM db yet. See more in the todo item in {{DistributedStorageHandler#listVolumes}} I will create JIRAs as following up tasks for them, to avoid we stuck with a big patch. > Ozone: KSM : add listVolumes > ---------------------------- > > Key: HDFS-11773 > URL: https://issues.apache.org/jira/browse/HDFS-11773 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone > Affects Versions: HDFS-7240 > Reporter: Anu Engineer > Assignee: Weiwei Yang > Attachments: HDFS-11773-HDFS-7240.001.patch, listVolume_tests.log > > > List volume call can be used in three different contexts. One is for the administrators to list all volumes in a cluster. Second is for the administrator to list the volumes owned by a specific user. Third is a user listing the volumes owned by himself/herself. > Since these calls can return large number of entries the rest protocol supports paging. Paging is supported by the use of prevKey, prefix and maxKeys. The caller is aware the this call is neither atomic nor consistent. So we can iterate over the list even while changes are happening to the list. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org