Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 12 Jun 2017 12:04:00 +0000 (UTC)
From: "Yiqun Lin (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13068287.1493683278000.1057.1497269040057@Atlassian.JIRA>
In-Reply-To: <JIRA.13068287.1493683278000@Atlassian.JIRA>
References: <JIRA.13068287.1493683278000@Atlassian.JIRA> <JIRA.13068287.1493683278945@jira-lw-us.apache.org>
Subject: [jira] [Updated] (HDFS-11736) OIV tests should not write outside
 'target' directory.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 12 Jun 2017 12:04:05 -0000


     [ https://issues.apache.org/jira/browse/HDFS-11736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yiqun Lin updated HDFS-11736:
-----------------------------
    Attachment: HDFS-11736.002.patch

Thanks [~ajisakaa] for your review. I found one failure test {{TestStandbyCheckpoints}} is related. The root cause of this is that the OivImgDir doesn't be deleted after each test methods.
Attach the new patch to address this. Found one difference in branch-2.7, the method {{GenericTestUtils#getTempDir}} doesn't exist. And there are only two places using {{Files.createTempDir()}}. Will attach the patch for branch-2.7 soon.

> OIV tests should not write outside 'target' directory.
> ------------------------------------------------------
>
>                 Key: HDFS-11736
>                 URL: https://issues.apache.org/jira/browse/HDFS-11736
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Konstantin Shvachko
>            Assignee: Yiqun Lin
>              Labels: newbie++, test
>         Attachments: HDFS-11736.001.patch, HDFS-11736.002.patch
>
>
> A few tests use {{Files.createTempDir()}} from Guava package, but do not set {{java.io.tmpdir}} system property. Thus the temp directory is created in unpredictable places and is not being cleaned up by {{mvn clean}}.
> This was probably introduced in {{TestOfflineImageViewer}} and then replicated in {{TestCheckpoint}}, {{TestStandbyCheckpoints}}.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org