Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 15 Jun 2017 03:14:00 +0000 (UTC)
From: "James Clampffer (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13049736.1489089674000.21457.1497496440038@Atlassian.JIRA>
In-Reply-To: <JIRA.13049736.1489089674000@Atlassian.JIRA>
References: <JIRA.13049736.1489089674000@Atlassian.JIRA> <JIRA.13049736.1489089674756@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HDFS-11518) libhdfs++: Add a build option to
 skip building examples, tests, and tools
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 15 Jun 2017 03:14:04 -0000


    [ https://issues.apache.org/jira/browse/HDFS-11518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049951#comment-16049951 ] 

James Clampffer commented on HDFS-11518:
----------------------------------------

Nice!  Change looks good to me.  Could you just add a comment towards the top of that CMakeLists file (under the license stuff) listing the option name and what it does?  I assume eventually there will be a few more build config options so an example on how to document one will help keep things consistent.  A quick example of what you'd add to a cmake invocation to get it into this mode from the command line would also be helpful e.g. cmake -DHDFSPP_LIBRARY_ONLY:<not sure if type matters> <value>.  Will +1 once that's added.

> libhdfs++: Add a build option to skip building examples, tests, and tools
> -------------------------------------------------------------------------
>
>                 Key: HDFS-11518
>                 URL: https://issues.apache.org/jira/browse/HDFS-11518
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: James Clampffer
>            Assignee: Anatoli Shein
>         Attachments: HDFS-11518.HDFS-8707.000.patch
>
>
> Adding a flag to just build the core library without tools, examples, and tests will make it easier and lighter weight to embed the libhdfs++ source as a third-party component of other projects.  It won't need to look for a JDK, valgrind, and gmock and won't generate a handful of binaries that might not be relevant to other projects during normal use.
> This should also make it a bit easier to wire into other build frameworks since there won't be standalone binaries that need the path to other libraries like protobuf while the library builds.  They just need to be around while the project embedding libhdfs++ gets linked.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org