hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chen Liang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12050) Ozone: StorageHandler: Implementation of "close" for releasing resources during shutdown
Date Wed, 28 Jun 2017 17:52:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066943#comment-16066943
] 

Chen Liang commented on HDFS-12050:
-----------------------------------

Thanks [~nandakumar131] for the catch! The patch LGTM, one question though, I'm not entirely
sure about this, but do we also need to call {{clientCache.cleanup()}} somewhere? (e.g. before
clientCache.invalidateAll()).

> Ozone: StorageHandler: Implementation of "close" for releasing resources during shutdown
> ----------------------------------------------------------------------------------------
>
>                 Key: HDFS-12050
>                 URL: https://issues.apache.org/jira/browse/HDFS-12050
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Nandakumar
>            Assignee: Nandakumar
>            Priority: Minor
>         Attachments: HDFS-12050-HDFS-7240.000.patch
>
>
> When we use DistributedStorageHandler and call {{newKeyWriter}}, it will create {{XceiverClientSpi}}
and add it to clientCache which will create a non-daemon {{nioEventLoopGroup}} thread. Since
{{XceiverClientManager#releaseClient}} doesn't invalidate the client, close is not called
on the client object. Cleanup is triggered as part of both eviction as well as releaseClient,
but the connection is closed only when both of the conditions are satisfied.
> This {{StorageHandler#close}} can be used to close the connections during shutdown.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message