hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yiqun Lin (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-12030) Ozone: CLI: support infoKey command
Date Wed, 28 Jun 2017 06:45:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065999#comment-16065999
] 

Yiqun Lin edited comment on HDFS-12030 at 6/28/17 6:44 AM:
-----------------------------------------------------------

Thanks for the reivew, [~cheersyang].
bq. line 527: is this the correct URL? I was expecting something like ...
I have tried the way as you commented, it will go into the {{getKey}} processor rather than
{{getKeyInfo}}.

bq. Can we add a test case to test info a non-exist key to make sure we get KEY_NOT_FOUND
error ?...
Yes, actually {{ErrorTable}} didn't define a code like {{KEY_NOT_FOUND}} that defined in KSM.
But this error info will be passed into the exception message. So the error message can be
shown correctly with {{HTTP_INTERNAL_ERROR}} error code. The response output tested from my
local:

{noformat}
Command Failed : {"httpCode":500,"shortMessage":"internalServerError","resource":"yiqun01.lin","message":"Lookup
key failed, error:KEY_NOT_FOUND","requestID":"586a4438-87b2-47fb-8118-b4d2368f2768","hostName":"VIP-20161102IRH"}
{noformat}
Attach the updated patch. Other comments are addressed in the patch. Thanks for the review.



was (Author: linyiqun):
Thanks for the reivew, [~cheersyang].
bq. line 527: is this the correct URL? I was expecting something like ...
I have tried the way as you commented, it will go into the {{getKey}} processor rather than
{{getKeyInfo}}.

bq. Can we add a test case to test info a non-exist key to make sure we get KEY_NOT_FOUND
error ?...
Yes, actually {{ErrorTable}} didn't define a code like {{KEY_NOT_FOUND}} that defined in KSM.
But this error info will be passed into the exception message. So the error message can be
shown correctly with {{HTTP_INTERNAL_ERROR}} error code. The response output tested from my
local:

{noformat}
Command Failed : {"httpCode":500,"shortMessage":"internalServerError","resource":"yiqun01.lin","message":"Lookup
key failed, error:KEY_NOT_FOUND","requestID":"586a4438-87b2-47fb-8118-b4d2368f2768","hostName":"VIP-20161102IRH"}
{noformat}
Attach the updated patch. Thanks for the review.


> Ozone: CLI: support infoKey command
> -----------------------------------
>
>                 Key: HDFS-12030
>                 URL: https://issues.apache.org/jira/browse/HDFS-12030
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Xiaoyu Yao
>            Assignee: Yiqun Lin
>         Attachments: HDFS-12030-HDFS-7240.001.patch, HDFS-12030-HDFS-7240.002.patch,
HDFS-12030-HDFS-7240.003.patch
>
>
> {code}
> HW11717:ozone xyao$ hdfs oz -infoKey http://localhost:9864/vol-2/bucket-1/key-1 -user
xyao 
> Command Failed : {"httpCode":0,"shortMessage":"Not supported yet","resource":null,"message":"Not
supported yet","requestID":null,"hostName":null}
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message