hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
Date Mon, 26 Jun 2017 17:54:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063503#comment-16063503

Xiaoyu Yao commented on HDFS-12030:

Thanks [~linyiqun] for working on this. The patch looks good to me overall. Here are a few

Line 55: remove the unused parameter info

Line 63-108: we should have a separate procesor for getKeyInfo as commented in the Keys.java

Line 90-99: Since this is purely a KSM metadata operation, I think we should define a new
like getKeyInfo for Keys interface instead of mixing with the existing one to get the key
designed for streaming data. 

Line 441/448: I don't think we should set the keySize here. Many times, the callers make this
call to figure
out the size of the key from KSM.

Can you add a test to the oz shell command infoKey?

> Ozone: CLI: support infoKey command
> -----------------------------------
>                 Key: HDFS-12030
>                 URL: https://issues.apache.org/jira/browse/HDFS-12030
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Xiaoyu Yao
>            Assignee: Yiqun Lin
>         Attachments: HDFS-12030-HDFS-7240.001.patch
> {code}
> HW11717:ozone xyao$ hdfs oz -infoKey http://localhost:9864/vol-2/bucket-1/key-1 -user
> Command Failed : {"httpCode":0,"shortMessage":"Not supported yet","resource":null,"message":"Not
supported yet","requestID":null,"hostName":null}
> {code}

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message