hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yongjun Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11976) Examine code base for cases that exception is thrown from finally block and fix it
Date Fri, 16 Jun 2017 06:25:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051449#comment-16051449
] 

Yongjun Zhang commented on HDFS-11976:
--------------------------------------

That's great [~pavgustinov]! very nice tool and thank you so much!



> Examine code base for cases that exception is thrown from finally block and fix it
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-11976
>                 URL: https://issues.apache.org/jira/browse/HDFS-11976
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Yongjun Zhang
>
> If exception X is thrown in try block, and exception Y is thrown is finally block, X
will be swallowed.
> In addition, finally block is used to ensure resources are released properly in general.
If we throw exception from there, some resources may be leaked. So it's not recommended to
throw exception in the finally block
> I caught one today and reported HDFS-11794, creating this jira as a master one to catch
other similar cases.
> Hope there is some static analyzer to find all.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message