hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11972) CBlocks use wrong OPT env vars
Date Thu, 15 Jun 2017 15:40:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050640#comment-16050640
] 

Anu Engineer commented on HDFS-11972:
-------------------------------------

+1, Looks good to me. Thanks for taking care of this. Let us hold off on committing this and
give Allen a chance to look at it.



> CBlocks use wrong OPT env vars
> ------------------------------
>
>                 Key: HDFS-11972
>                 URL: https://issues.apache.org/jira/browse/HDFS-11972
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs
>            Reporter: Allen Wittenauer
>            Assignee: Mukul Kumar Singh
>         Attachments: HDFS-11972-HDFS-7240.001.patch
>
>
> Current codebase does:
> {code}
>       hadoop_debug "Appending HADOOP_CBLOCK_OPTS onto HADOOP_OPTS" 
>       HADOOP_OPTS="${HADOOP_OPTS} ${HADOOP_CBLOCK_OPTS}"
> ...  
>       hadoop_debug "Appending HADOOP_JSCSI_OPTS onto HADOOP_OPTS"
>       HADOOP_OPTS="${HADOOP_OPTS} ${HADOOP_JSCSI_OPTS}"
> {code}
> This code block breaks the consistency with the rest of the shell scripts:
> a) It should be HDFS_CBLOCKSERVER_OPTS, HDFS_JSCSI_OPTS
> b) _OPTS, unless they are a deprecated form or some other special case, are already/automatically
appended; there is no need to do them specifically
> Also, a description of these env vars should be hadoop-env.sh for documentation purposes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message