hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-11972) cblockserver uses wrong OPT env var
Date Wed, 14 Jun 2017 03:25:01 GMT

     [ https://issues.apache.org/jira/browse/HDFS-11972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Allen Wittenauer updated HDFS-11972:
------------------------------------
    Description: 
Current codebase does:

{code}
      hadoop_debug "Appending HADOOP_CBLOCK_OPTS onto HADOOP_OPTS" 
      HADOOP_OPTS="${HADOOP_OPTS} ${HADOOP_CBLOCK_OPTS}"

...  

      hadoop_debug "Appending HADOOP_JSCSI_OPTS onto HADOOP_OPTS"
      HADOOP_OPTS="${HADOOP_OPTS} ${HADOOP_JSCSI_OPTS}"
{code}

This code block breaks the consistency with the rest of the shell scripts:

a) It should be HDFS_CBLOCKSERVER_OPTS, HDFS_JSCSI_OPTS
b) _OPTS, unless they are a deprecated form or some other special case, are already/automatically
appended; there is no need to do them specifically

Also, a description of this env var should be hadoop-env.sh so that it is properly documented.

  was:
Current codebase does:

{code}
      hadoop_debug "Appending HADOOP_CBLOCK_OPTS onto HADOOP_OPTS" 
      HADOOP_OPTS="${HADOOP_OPTS} ${HADOOP_CBLOCK_OPTS}"
{code}

This code block breaks the consistency with the rest of the shell scripts:

a) It should be HDFS_CBLOCKSERVER_OPTS
b) HDFS_CBLOCKSERVER_OPTS is already/automatically appended; there is no need to do it specifically

Also, a description of this env var should be hadoop-env.sh so that it is properly documented.


> cblockserver uses wrong OPT env var
> -----------------------------------
>
>                 Key: HDFS-11972
>                 URL: https://issues.apache.org/jira/browse/HDFS-11972
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs
>            Reporter: Allen Wittenauer
>
> Current codebase does:
> {code}
>       hadoop_debug "Appending HADOOP_CBLOCK_OPTS onto HADOOP_OPTS" 
>       HADOOP_OPTS="${HADOOP_OPTS} ${HADOOP_CBLOCK_OPTS}"
> ...  
>       hadoop_debug "Appending HADOOP_JSCSI_OPTS onto HADOOP_OPTS"
>       HADOOP_OPTS="${HADOOP_OPTS} ${HADOOP_JSCSI_OPTS}"
> {code}
> This code block breaks the consistency with the rest of the shell scripts:
> a) It should be HDFS_CBLOCKSERVER_OPTS, HDFS_JSCSI_OPTS
> b) _OPTS, unless they are a deprecated form or some other special case, are already/automatically
appended; there is no need to do them specifically
> Also, a description of this env var should be hadoop-env.sh so that it is properly documented.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message