hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Zhuge (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-11861) ipc.Client.Connection#sendRpcRequest should log request name
Date Thu, 08 Jun 2017 21:05:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043312#comment-16043312
] 

John Zhuge edited comment on HDFS-11861 at 6/8/17 9:04 PM:
-----------------------------------------------------------

Any IPC call without parameter will leave {{parameters}} as null, then NPE whenever toString
is called.

The reason why trunk does not have the issue:
* For TestClientToAMTokens, YARN-5163. "Migrate TestClientToAMTokens and TestClientRMTokens
tests from the old RPC engine. " replaced all {{client.ping()}} with {{client.ping(null, TestRpcBase.newEmptyRequest())}}.
* TestClientProtocolWithDelegationToken is removed in trunk

Filed HADOOP-14511 "WritableRpcEngine.Invocation#toString NPE on null parameters", and submitted
patch 001.


was (Author: jzhuge):
Any IPC call without parameter will leave {{parameters}} as null, then NPE whenever toString
is called.

The reason why trunk does not have the issue:
* For TestClientToAMTokens, YARN-5163. "Migrate TestClientToAMTokens and TestClientRMTokens
tests from the old RPC engine. " replaced all {{client.ping()}} with {{client.ping(null, TestRpcBase.newEmptyRequest())}}.
* TestClientProtocolWithDelegationToken is removed in trunk

Filed HDFS-11954 "WritableRpcEngine.Invocation#toString should handle null parameters". Will
upload patch shortly.

> ipc.Client.Connection#sendRpcRequest should log request name
> ------------------------------------------------------------
>
>                 Key: HDFS-11861
>                 URL: https://issues.apache.org/jira/browse/HDFS-11861
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 2.6.0
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>            Priority: Trivial
>              Labels: supportability
>             Fix For: 2.9.0, 3.0.0-alpha4, 2.8.2
>
>         Attachments: HDFS-11861.001.patch
>
>
> {{ipc.Client.Connection#sendRpcRequest}} only logs the call id.
> {code}
>                 if (LOG.isDebugEnabled())
>                   LOG.debug(getName() + " sending #" + call.id);
> {code}
> It'd be much more helpful to log request name for several benefits:
> * Find out which requests sent to which target
> * Correlate with the debug log in {{ipc.Server.Handler}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message