hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Badger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11861) ipc.Client.Connection#sendRpcRequest should log request name
Date Thu, 08 Jun 2017 15:17:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042837#comment-16042837
] 

Eric Badger commented on HDFS-11861:
------------------------------------

[~jzhuge], [~xiaochen], this commit has broken the following tests in branch-2.8 and branch-2:
TestClientProtocolWithDelegationToken.testDelegationTokenRpc
TestClientToAMTokens.testClientToAMTokens
TestClientToAMTokens.testClientTokenRace

> ipc.Client.Connection#sendRpcRequest should log request name
> ------------------------------------------------------------
>
>                 Key: HDFS-11861
>                 URL: https://issues.apache.org/jira/browse/HDFS-11861
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 2.6.0
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>            Priority: Trivial
>              Labels: supportability
>             Fix For: 2.9.0, 3.0.0-alpha4, 2.8.2
>
>         Attachments: HDFS-11861.001.patch
>
>
> {{ipc.Client.Connection#sendRpcRequest}} only logs the call id.
> {code}
>                 if (LOG.isDebugEnabled())
>                   LOG.debug(getName() + " sending #" + call.id);
> {code}
> It'd be much more helpful to log request name for several benefits:
> * Find out which requests sent to which target
> * Correlate with the debug log in {{ipc.Server.Handler}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message