hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rakesh R (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-11670) [SPS]: Add CLI command for satisfy storage policy operations
Date Tue, 13 Jun 2017 12:24:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047789#comment-16047789
] 

Rakesh R edited comment on HDFS-11670 at 6/13/17 12:23 PM:
-----------------------------------------------------------

[~surendrasingh], patch looks almost OK to me. Please take care below comments.
# Documentation is not updated with the latest command changes. Please take care.
{code}
[-storagePolicySatisfierStatus]

### Storage Policy Satisfier Status

Check the status of Storage Policy Satisfier in namenode. If it is running, return 'Enabled'.
Otherwise return 'Disabled'.

* Command:

        hdfs storagepolicies -storagePolicySatisfierStatus
{code}
# For the {{isSPSRunning}} command, how about add validation for any unnecessary args passed.
Refer [CryptoAdmin.java#L176|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CryptoAdmin.java#L176]
{code}
      if (!args.isEmpty()) {
        System.err.print("Can't understand arguments: " +
          Joiner.on(" ").join(args) + "\n");
        System.err.println("Usage is " + getLongUsage());
        return 1;
      }
{code}


was (Author: rakeshr):
[~surendrasingh], patch looks almost OK to me. Please take care below comments.
# Documentation is not updated with the latest command changes. Please take care.
{code}
[-storagePolicySatisfierStatus]

### Storage Policy Satisfier Status

Check the status of Storage Policy Satisfier in namenode. If it is running, return 'Enabled'.
Otherwise return 'Disabled'.

* Command:

        hdfs storagepolicies -storagePolicySatisfierStatus
{code}
# Probably, we could add validation for any unnecessary args passed. Refer [CryptoAdmin.java#L176|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CryptoAdmin.java#L176]
{code}
      if (!args.isEmpty()) {
        System.err.print("Can't understand arguments: " +
          Joiner.on(" ").join(args) + "\n");
        System.err.println("Usage is " + getLongUsage());
        return 1;
      }
{code}

> [SPS]: Add CLI command for satisfy storage policy operations
> ------------------------------------------------------------
>
>                 Key: HDFS-11670
>                 URL: https://issues.apache.org/jira/browse/HDFS-11670
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: HDFS-10285
>            Reporter: Surendra Singh Lilhore
>            Assignee: Surendra Singh Lilhore
>         Attachments: HDFS-11670-HDFS-10285.001.patch, HDFS-11670-HDFS-10285.002.patch,
HDFS-11670-HDFS-10285.003.patch
>
>
> This jira to discuss and implement set of satisfy storage policy sub-commands. Following
are the list of sub-commands:
> # Schedule blocks to move based on file/directory policy:
> {code}hdfs storagepolicies -satisfyStoragePolicy -path <path>]{code}
> # Its good to have one command to check SPS is enabled or not. Based on this user can
take the decision to run the Mover:
> {code}
> hdfs storagepolicies -isSPSRunning
> {code} 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message