Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 25 May 2017 21:03:04 +0000 (UTC)
From: "Arpit Agarwal (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13074613.1495653692000.297400.1495746184411@Atlassian.JIRA>
In-Reply-To: <JIRA.13074613.1495653692000@Atlassian.JIRA>
References: <JIRA.13074613.1495653692000@Atlassian.JIRA> <JIRA.13074613.1495653692765@jira-lw-us.apache.org>
Subject: [jira] [Updated] (HDFS-11879) Fix JN sync interval in case of
 exception
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 25 May 2017 21:03:09 -0000


     [ https://issues.apache.org/jira/browse/HDFS-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arpit Agarwal updated HDFS-11879:
---------------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 3.0.0-alpha3
           Status: Resolved  (was: Patch Available)

Committed to trunk. The unit-test failures are unrelated.

Thanks for the contribution [~hanishakoneru].

> Fix JN sync interval in case of exception
> -----------------------------------------
>
>                 Key: HDFS-11879
>                 URL: https://issues.apache.org/jira/browse/HDFS-11879
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>             Fix For: 3.0.0-alpha3
>
>         Attachments: HDFS-11879.001.patch
>
>
> Currently, if there is an exception in _JournalNodeSyncer#syncJournal_, the sync daemon does not wait the specified interval before the next sync attempt. 
> In the following code block in _JournalNodeSyncer#startSyncJournalsDaemon_, Thread.sleep should be moved to a separate try catch block from _syncJournal()_ to avoid skipping it in case of exception.
> {code}
>         try {
>           if (!journal.isFormatted()) {
>             LOG.warn("Journal cannot sync. Not formatted.");
>           } else {
>             syncJournals();
>           }
>           Thread.sleep(journalSyncInterval);
>         } catch (Throwable t) {
>            .......
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org