Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 1 May 2017 21:56:04 +0000 (UTC)
From: "Xiaoyu Yao (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13066014.1492812885000.95522.1493675764411@Atlassian.JIRA>
In-Reply-To: <JIRA.13066014.1492812885000@Atlassian.JIRA>
References: <JIRA.13066014.1492812885000@Atlassian.JIRA> <JIRA.13066014.1492812885690@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HDFS-11693) Ozone: Add archive support to
 containers
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 01 May 2017 21:56:09 -0000


    [ https://issues.apache.org/jira/browse/HDFS-11693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991635#comment-15991635 ] 

Xiaoyu Yao commented on HDFS-11693:
-----------------------------------

Thanks [~anu] for working on the this. The patch looks good to me overall. I just have few questions:

Can we reuse the FileUtil#unZip and just add zip directory as part of FileUtil?

Compressor.java
Line 46: NIT: BUFFER->BUFFER_SIZE
Line 73-75: Can we define a new configuration key like {{hadoop.ozone.temp.dir}}
and have the default value set as ${hadoop.tmp.dir}/ozone in 

Do we support compress/decompress directory with subdirs? 
If we do, can we add test cases for directory/subdir/files in addition to 
the test case for directory/files. 

Line 123: Do we want to flush() before the outputstream is closed?

Decompressor.java
Line 43: NIT: BUFFER->BUFFER_SIZE
Line 124/126: destPath.getParent() can be replace with parent

TestArchive.java
Line 49-62: this can be wrapped as a test util for reuse.


> Ozone: Add archive support to containers
> ----------------------------------------
>
>                 Key: HDFS-11693
>                 URL: https://issues.apache.org/jira/browse/HDFS-11693
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>         Attachments: HDFS-11693-HDFS-7240.001.patch
>
>
> Add archive support to containers. This is a stepping stone to supporting copy containers.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org