Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5CB93200C80 for ; Thu, 11 May 2017 07:52:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5B908160BB4; Thu, 11 May 2017 05:52:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AACC2160B9C for ; Thu, 11 May 2017 07:52:08 +0200 (CEST) Received: (qmail 52903 invoked by uid 500); 11 May 2017 05:52:07 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 52883 invoked by uid 99); 11 May 2017 05:52:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 May 2017 05:52:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4B060CDAF4 for ; Thu, 11 May 2017 05:52:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 2swF3lWUr8zg for ; Thu, 11 May 2017 05:52:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5BC9B5FD6D for ; Thu, 11 May 2017 05:52:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 918B3E0D95 for ; Thu, 11 May 2017 05:52:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 49DC621E19 for ; Thu, 11 May 2017 05:52:04 +0000 (UTC) Date: Thu, 11 May 2017 05:52:04 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-11681) DatanodeStorageInfo#getBlockIterator() should return an iterator to an unmodifiable set. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 11 May 2017 05:52:09 -0000 [ https://issues.apache.org/jira/browse/HDFS-11681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005931#comment-16005931 ] Hudson commented on HDFS-11681: ------------------------------- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11722 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/11722/]) HDFS-11681. DatanodeStorageInfo#getBlockIterator() should return an (cdouglas: rev 51b671ef1844069888f976cd16f66c88f9bbc7de) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeStorageInfo.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestGetBlocks.java > DatanodeStorageInfo#getBlockIterator() should return an iterator to an unmodifiable set. > ---------------------------------------------------------------------------------------- > > Key: HDFS-11681 > URL: https://issues.apache.org/jira/browse/HDFS-11681 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Virajith Jalaparti > Assignee: Virajith Jalaparti > Fix For: 3.0.0-alpha3 > > Attachments: HDFS-11681.001.patch, HDFS-11681.002.patch > > > The iterator from {{DatanodeStorageInfo#getBlockIterator()}} should not be modifiable. Otherwise, calling {{remove}} on the iterator will remove blocks from {{DatanodeStorageInfo.blocks}}, a function that has to be performed by calling {{DatanodeStorageInfo#removeBlock}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org