Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AD037200CA3 for ; Wed, 3 May 2017 00:17:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id ABA68160BAC; Tue, 2 May 2017 22:17:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F1CF3160B9D for ; Wed, 3 May 2017 00:17:06 +0200 (CEST) Received: (qmail 74346 invoked by uid 500); 2 May 2017 22:17:06 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 74335 invoked by uid 99); 2 May 2017 22:17:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 May 2017 22:17:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A5DF11A00D0 for ; Tue, 2 May 2017 22:17:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id yfeNbX_eAxLV for ; Tue, 2 May 2017 22:17:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C9F235FB2C for ; Tue, 2 May 2017 22:17:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6132FE0905 for ; Tue, 2 May 2017 22:17:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1E18121DE2 for ; Tue, 2 May 2017 22:17:04 +0000 (UTC) Date: Tue, 2 May 2017 22:17:04 +0000 (UTC) From: "Chris Douglas (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-10630) Federation State Store FS Implementation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 02 May 2017 22:17:07 -0000 [ https://issues.apache.org/jira/browse/HDFS-10630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993893#comment-15993893 ] Chris Douglas commented on HDFS-10630: -------------------------------------- +1 lgtm Minor, not blocking commit * param javadoc for {{PeriodicService}} doesn't specify the time unit (ms) * The TimeUnit conversions from constants to millis don't seem necessary * {{+ conf.set(DFSConfigKeys.DFS_PERMISSIONS_ENABLED_KEY, "true");}} use conf.setBoolean * {{+ conf.set(FEDERATION_STORE_DRIVER_CLASS, clazz.getCanonicalName());}} use conf.setClass > Federation State Store FS Implementation > ---------------------------------------- > > Key: HDFS-10630 > URL: https://issues.apache.org/jira/browse/HDFS-10630 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs > Reporter: Inigo Goiri > Assignee: Jason Kace > Attachments: HDFS-10630.001.patch, HDFS-10630.002.patch, HDFS-10630-HDFS-10467-003.patch, HDFS-10630-HDFS-10467-004.patch, HDFS-10630-HDFS-10467-005.patch, HDFS-10630-HDFS-10467-006.patch, HDFS-10630-HDFS-10467-007.patch, HDFS-10630-HDFS-10467-008.patch, HDFS-10630-HDFS-10467-009.patch > > > Interface to store the federation shared state across Routers. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org