hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Surendra Singh Lilhore (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11883) [SPS] : Handle NPE in BlockStorageMovementTracker when dropSPSWork() called
Date Sat, 27 May 2017 05:08:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027199#comment-16027199
] 

Surendra Singh Lilhore commented on HDFS-11883:
-----------------------------------------------

Thanks [~umamaheswararao] for review..

bq. From next iteration, you will not find any moverTaskFeatures as it was already cleared.
So, this newly added trackID will be leaked right?
yes, you are right. It is race condition..

I feel we can add double check in {{if (blocksMoving.isEmpty()) {}} some thing like this...

{code}
          if (blocksMoving.isEmpty() || moverTaskFutures.get(trackId) == null) {
            .........
	    .........
            movementResults.remove(trackId);
          }
{code}

> [SPS] : Handle NPE in BlockStorageMovementTracker when dropSPSWork() called
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-11883
>                 URL: https://issues.apache.org/jira/browse/HDFS-11883
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>    Affects Versions: HDFS-10285
>            Reporter: Surendra Singh Lilhore
>            Assignee: Surendra Singh Lilhore
>         Attachments: HDFS-11883.001.patch, HDFS-11883-HDFS-10285.001.patch
>
>
> {noformat}
> Exception in thread "BlockStorageMovementTracker" java.lang.NullPointerException
> at org.apache.hadoop.hdfs.server.datanode.BlockStorageMovementTracker.run(BlockStorageMovementTracker.java:91)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message