hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11865) Ozone: Do not initialize Ratis cluster during datanode startup
Date Wed, 24 May 2017 23:58:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023912#comment-16023912
] 

Xiaoyu Yao commented on HDFS-11865:
-----------------------------------

Thanks [~szetszwo] for working on this. The patch looks excellent to me. I just have few minor
issues:

OzoneConfigKeys.java
Can you add some comments on how to configure and use dfs.container.ratis.server.id  (e.g.
via RaftClient#reinitialize) in a Ratis cluster?

XceiverServerRatis.java
Line 63: on Datanode without dfs.container.ratis.server.id configured, the id will be null.
Will that cause NPE on line 86 when run RaftPeerId.valueOf(id)? Maybe this is an invalid configuration.
Can we add some logic to handle it gracefully. 

TestContainerServer.java
Line 106: Can you elaborate on the reason to disable test with more than 1 node {{runTestClientServerRatis(NETTY,
3);}}? Maybe add a TODO to fix it later?

> Ozone: Do not initialize Ratis cluster during datanode startup
> --------------------------------------------------------------
>
>                 Key: HDFS-11865
>                 URL: https://issues.apache.org/jira/browse/HDFS-11865
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: HDFS-11865-HDFS-7240.20170522.patch, HDFS-11865-HDFS-7240.20170523.patch
>
>
> During a datanode startup, we current pass dfs.container.ratis.conf so that the datanode
is bound to a particular Ratis cluster.
> In this JIRA, we change Datanode that the datanode is no longer bound to any Ratis cluster
during startup. We use the Ratis reinitialize request (RATIS-86) to set up a Ratis cluster
later on.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message