hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11832) Switch leftover logs to slf4j format in BlockManager.java
Date Fri, 19 May 2017 17:09:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017669#comment-16017669
] 

Akira Ajisaka commented on HDFS-11832:
--------------------------------------

Thanks [~10075197], I think this is not right. In the following code, {{Arrays.asList(blocks)}}
is called to evaluate the variable before calling {{LOG.debug()}}.
{code}
LOG.debug("blocks = {}", java.util.Arrays.asList(blocks));
{code}

bq. However, the second form will outperform the first form by a factor of at least 30, in
case of a disabled logging statement.
The second form skips {{Object.toString()}}, so it is faster. However, the form cannot skip
the method call in the variable.

> Switch leftover logs to slf4j format in BlockManager.java
> ---------------------------------------------------------
>
>                 Key: HDFS-11832
>                 URL: https://issues.apache.org/jira/browse/HDFS-11832
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.7.0, 2.8.0, 3.0.0-alpha1
>            Reporter: Hui Xu
>            Assignee: Chen Liang
>            Priority: Minor
>         Attachments: HDFS-11832.001.patch, HDFS-11832.002.patch, HDFS-11832.003.patch,
HDFS-11832.004.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> HDFS-7706 Switch BlockManager logging to use slf4j. But the logging formats were not
modified appropriately. For example:
>       if (LOG.isDebugEnabled()) {
>         LOG.debug("blocks = " + java.util.Arrays.asList(blocks));
>       }
> These codes should be modified to:
>       LOG.debug("blocks = {}", java.util.Arrays.asList(blocks));



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message