hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11788) Ozone : add DEBUG CLI support for nodepool db file
Date Tue, 09 May 2017 23:50:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003779#comment-16003779
] 

Xiaoyu Yao commented on HDFS-11788:
-----------------------------------

Thanks [~vagarychen] for working on this. Patch v2 looks pretty good to me. I only have some
minor suggestions:
 
1. Can we use the try-with-resource for {{dbStore}} so that the store can be closed even exception
is throw in the middle of the insert into sqllite 
{code}
365	    LevelDBStore dbStore = new LevelDBStore(dbFile, dbOptions);
{code}

2. Does level db support open by multiple processes? Do we need any special Option/flag when
opening a live nodepool/container db running with SCM?
If we assume this is an offline tool, we should comment or document it somewhere.

  

> Ozone : add DEBUG CLI support for nodepool db file
> --------------------------------------------------
>
>                 Key: HDFS-11788
>                 URL: https://issues.apache.org/jira/browse/HDFS-11788
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>         Attachments: HDFS-11788-HDFS-7240.001.patch, HDFS-11788-HDFS-7240.002.patch
>
>
> This is a following-up of HDFS-11698. This JIRA adds the converting of nodepool.db levelDB
file.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message