hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Weiwei Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11781) Ozone: KSM: Add deleteKey
Date Wed, 31 May 2017 14:47:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031260#comment-16031260
] 

Weiwei Yang commented on HDFS-11781:
------------------------------------

Hi [~yuanbo]

Thanks for the patch. I think we miss something here. The patch only cleans up the name space
(KSM database), but leaves the object data in containers on datanodes. I think those need
to be deleted as well. You may want to make this operation async, that says the delete operation
will success as long as the name space successfully updated and the container data is marked
as *staled*.  The container server on datanode scans staled container data and delete them
from disk in a certain time interval. [~anu], please confirm.

Some other minor comments:

# DistributedStorageHandler.java line 360, it doesn't seem to need set data size for delete
operation.
# KeyManager.java: please add a bit more annotation to deleteKey(KsmKeyArgs args), explain
what happens if the specified key exist or not exist.
# KeyManagerImpl.java: line 146 keyKey -> objectKey
# KeySpaceManagerProtocol.java and KeySpaceManagerProtocol: minor Delete an existing key.
-> Deletes an existing key.

Thanks

> Ozone: KSM: Add deleteKey
> -------------------------
>
>                 Key: HDFS-11781
>                 URL: https://issues.apache.org/jira/browse/HDFS-11781
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Yuanbo Liu
>         Attachments: HDFS-11781-HDFS-7240.001.patch
>
>
> Add support for removing a key.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message