hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11778) Ozone: KSM: add getBucketInfo
Date Tue, 23 May 2017 23:30:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022078#comment-16022078
] 

Xiaoyu Yao commented on HDFS-11778:
-----------------------------------

Thanks [~nandakumar131] for working on this. The patch looks good to me overall. Here are
some minor issues:

DistributedStorageHandler.java
Line 271-274: Currently the KSM#getBucketInfo returns KsmBucketInfo. But it does not contains
any key/spaceUsage information of the bucket. We will need to revisit this for the keyCount
and spaceUsed once putKey is added. I'm OK with this as-is now.

KeySpaceManagerProto.proto
Line 192: I think we can just keep using the BucketInfo as the parameter for CreateBucketRequest.
The add/remove ACL is mainly for setBucket. BucketInfo is good enough for CreateBucket/GetBuckert.

KeySpaceManagerProtocolClientSideTranslatorPB.java
Line 269: Same as above.

Line 311: the IOException message needs to be updated. 

KsmBucketArgs.java
Line 37: bucketInfo has an aclList which will usually not needed to coexist with addAcls and
removeAcls.
Any reason for changing the current KsmBucketArgs?

My understanding is BucketInfo/KsmBucketInfo are used for createBucket's input parameter and
getBucket's output.
BucketArgs/KsmBucketArgs are used solely for setBucket input parameter.

MetadataManagerImpl.java
Line 103: NIT: the code below is explanatory, the extra comment can be removed.


> Ozone: KSM: add getBucketInfo
> -----------------------------
>
>                 Key: HDFS-11778
>                 URL: https://issues.apache.org/jira/browse/HDFS-11778
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Nandakumar
>         Attachments: HDFS-11778-HDFS-7240.000.patch, HDFS-11778-HDFS-7240.001.patch
>
>
> Returns the bucket information if the bucket exists.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message