hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nandakumar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11776) Ozone: KSM: add SetBucketProperty
Date Fri, 26 May 2017 18:11:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026617#comment-16026617
] 

Nandakumar commented on HDFS-11776:
-----------------------------------

Thanks for the review [~cheersyang].

bq. why we need to check the existence of volume here? Why not simply check the existence
of bucketKey ?
This is because we want to return specific errors like VOLUME_NOT_FOUND and BUCKET_NOT_FOUND.
If multiple the get call on levelDB is affecting the performance too much we can make this
a single call and return a generic error like INVALID_KEY.
bq. I think we can remove LOG.error lines in 163 and 170. As such error is supposed to be
handled by clients, not necessary to leave a footprint in server side.
I agree, for now all the Volume and Bucket API's have this kind of logging. I'm happy to create
a new jira to track and remove all such log messages.
bq. But I doubt if this can work because BucketArgs#getIsVersionEnabled still returns boolean
isVersionEnabled_.
{{isVersionEnabled}} in {{KsmBucketArgs}} is changed from {{boolean}} to {{Boolean}} in HDFS-11778
bq. TestKeySpaceManager
Sure, will add a new test case for {{setIsVersionEnabled}} and will cover the scenario that
you have described.

> Ozone: KSM: add SetBucketProperty
> ---------------------------------
>
>                 Key: HDFS-11776
>                 URL: https://issues.apache.org/jira/browse/HDFS-11776
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Nandakumar
>         Attachments: HDFS-11776-HDFS-7240.000.patch
>
>
> Allows changing the properties of an existing bucket. Properties supported by this call
are
> # ACLs - Allows changing ACLs on a existing bucket.
> # StorageType - Allows users to control where the bucket should live. we ignore this
for the time being, since SCM does not expose APIs for this yet.
> # Versioning - Enables versioning on buckets. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message