hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chen Liang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11775) Ozone: KSM : add createBucket
Date Wed, 17 May 2017 18:49:05 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014610#comment-16014610
] 

Chen Liang commented on HDFS-11775:
-----------------------------------

the patch looks pretty good to me! only a couple minor things,

- seems {{TestBucketManagerImpl#testCreateBucket}} only makes sure there is no exception.
Can we also check if the bucket is correctly created? e.g. read the metadata and verify that
the correct bucket info is indeed there. In the case that this is too tricky to do without
getBucket() implemented, maybe we can just add a TODO note and leave for future.
- how about adding some wrappers to {{MetadataManager}} such that we remove {{getLevelDBStore()}}
and {{metadataManager.getLevelDBStore().get()}} can be shortened to just {{metadataManager.get()}}?
similarly {{metadataManager.getReadWriteLock().writeLock().lock()}} to, maybe just {{metadataManager.lock()}}?
This could also help if we are to implement a non-leveldb-based MetadataManagerImpl class,
e.g. a mock metadata manager class for testing purpose.

> Ozone: KSM : add createBucket 
> ------------------------------
>
>                 Key: HDFS-11775
>                 URL: https://issues.apache.org/jira/browse/HDFS-11775
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Nandakumar
>         Attachments: HDFS-11775-HDFS-7240.000.patch, HDFS-11775-HDFS-7240.001.patch,
HDFS-11775-HDFS-7240.002.patch, HDFS-11775-HDFS-7240.003.patch, HDFS-11775-HDFS-7240.004.patch,
HDFS-11775-HDFS-7240.005.patch, HDFS-11775-HDFS-7240.006.patch
>
>
> Creates a bucket if it does not exist. A precondition to creating a bucket is that a
parent volume must exist.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message