hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nandakumar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11775) Ozone: KSM : add createBucket
Date Wed, 17 May 2017 17:28:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014452#comment-16014452

Nandakumar commented on HDFS-11775:

Thanks for the review [~msingh].

=> please rename KeyspaceManagerProtocol.java to KeySpaceManagerProtocol.java, this results
in compilation failure
Rename is already there in previous patches.
=> BucketManagerImpl:35 - define DELIMITER in OzoneConsts.java
=> BucketManagerImpl:88 - please rename the comment
Actually the logic is to check the existence of volume before creating bucket
Changed the comment "Check if the volume already exists" -> "Check if the volume exists"
=> DistributedStorageHandler:187 - build is already being called in 188
=> OzoneAcl.java, please add comments to this new function
Comment added
=> TestBucketManagerImpl.java is missing the licensing

Uploaded patch 005 incorporating review comments.

> Ozone: KSM : add createBucket 
> ------------------------------
>                 Key: HDFS-11775
>                 URL: https://issues.apache.org/jira/browse/HDFS-11775
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Nandakumar
>         Attachments: HDFS-11775-HDFS-7240.000.patch, HDFS-11775-HDFS-7240.001.patch,
HDFS-11775-HDFS-7240.002.patch, HDFS-11775-HDFS-7240.003.patch, HDFS-11775-HDFS-7240.004.patch,
> Creates a bucket if it does not exist. A precondition to creating a bucket is that a
parent volume must exist.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message