hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11770) Ozone: KSM: Add setVolumeProperty
Date Fri, 19 May 2017 17:30:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017704#comment-16017704
] 

Xiaoyu Yao commented on HDFS-11770:
-----------------------------------

Thanks [~msingh] for working on this. The patch looks good to me overall. Just a few minor
issues:

BucketManagerImpl.java
Line 96-97, the order of the parameters volumeName/bucketName should be reversed.

MetadataManager.java
NIT: we can remove the DB from these methods.
getDBVolumeKey -> getVolumeKey()
getDBUserKey -> getUserKey
...

VolumeMangerImpl.java
Line 128-131 NIT: can we rename volumeName as we are retrieving the volumeInfo bytes here?

Let's combine HDFS-11772 getVolumeInfo with this ticket. Otherwise, we can't test or validate
the create or set result.

The validation for enforcement of quota won't be available until the Key API is ready. We
can handle that in a separate JIRA.


> Ozone: KSM: Add setVolumeProperty
> ---------------------------------
>
>                 Key: HDFS-11770
>                 URL: https://issues.apache.org/jira/browse/HDFS-11770
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Anu Engineer
>            Assignee: Mukul Kumar Singh
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-11770-HDFS-7240.001.patch, HDFS-11770-HDFS-7240.002.patch,
HDFS-11770-HDFS-7240.003.patch
>
>
> SetVolumeProperty allows Ozone administrators to change the ownership of a volume and
quota.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message