hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11768) Ozone: KSM: Create Key Space manager service
Date Wed, 10 May 2017 18:48:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005206#comment-16005206
] 

Xiaoyu Yao commented on HDFS-11768:
-----------------------------------

Thanks [~anu] for working on this. The patch looks pretty good to me. I just have few minor
comments below.

*pom.xml*
Should we rename KeyspaceManager.proto -> KeySpaceManager.proto

*VolumeArgs.java*
Line 33: can you add a comment on keyValueMap or rename?
Line 41: extra space between param and keyValueMap

*KeyspaceManagerProtocol.java*
rename to KeySpaceManagerProtocol.java for consistency.

Line 89: remove the extra "volume"

*ScmConfigKeys.java*
Should we have a separate KsmConfigKeys.java for these KSM keys

*KeyspaceManager.proto*
Can we pull KeyValue from DatanodeContainerProtocol.proto into Ozone.proto as it
seems to be the only one used here.

The SetVolumePropertyRequest does not support change the attributes via KeyValue Map.
This can be added later with HDFS-11770.

Can we add a test for KSM address/port similar to testGetScmDataNodeAddress?

*KeyspaceManagerProtocolServerSideTranslatorPB.java*
KeyspaceManagerProtocolServerSideTranslatorPB -> KeySpaceManagerProtocolServerSideTranslatorPB
for consistency

> Ozone: KSM: Create Key Space manager service
> --------------------------------------------
>
>                 Key: HDFS-11768
>                 URL: https://issues.apache.org/jira/browse/HDFS-11768
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>         Attachments: HDFS-11768-HDFS-7240.001.patch, ozone-key-space.pdf
>
>
> KSM is the namespace manager for Ozone. KSM relies on SCM to achieve block functions.
Ozone handler -- The rest protocol frontend talks to KSM and SCM to get datanode addresses.
> This JIRA will add the service as well as add the protobuf definitions needed to work
with KSM.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message