hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vrushali C (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11731) Balancer.run() prints redundant included, excluded, source nodes.
Date Thu, 04 May 2017 22:01:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997506#comment-15997506
] 

Vrushali C commented on HDFS-11731:
-----------------------------------

If I am not mistaken, the 
{code}
LOG.info("parameters = " + p);
{code}
at
https://github.com/apache/hadoop/blob/branch-2/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java#L675

would invoke the BalancerParameters#toString 
https://github.com/apache/hadoop/blob/branch-2/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancerParameters.java#L98

which prints the size of those sets.

The next three lines :
{code}
    LOG.info("included nodes = " + p.getIncludedNodes());
    LOG.info("excluded nodes = " + p.getExcludedNodes());
    LOG.info("source nodes = " + p.getSourceNodes());
{code}
would print the elements in those sets. In that case, it would not be redundant? 


> Balancer.run() prints redundant included, excluded, source nodes.
> -----------------------------------------------------------------
>
>                 Key: HDFS-11731
>                 URL: https://issues.apache.org/jira/browse/HDFS-11731
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: balancer & mover
>    Affects Versions: 2.8.0
>            Reporter: Konstantin Shvachko
>              Labels: newbie
>
> Included, excluded, and source nodes are printed twice by the Balancer. First as part
of {{BalancerParameters.toString()}} in
> {code}
>     LOG.info("parameters = " + p);
> {code}
> And then separately
> {code}
>     LOG.info("included nodes = " + p.getIncludedNodes());
>     LOG.info("excluded nodes = " + p.getExcludedNodes());
>     LOG.info("source nodes = " + p.getSourceNodes());
> {code}
> The latter can be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message