hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11722) Change Datanode file IO profiling sampling to percentage
Date Mon, 01 May 2017 15:40:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990975#comment-15990975
] 

Arpit Agarwal commented on HDFS-11722:
--------------------------------------

The patch looks good. Minor comment.
{code}
if (fileIOSamplingPercentage < 0.0001) {
{code}
This check should be changed to compare with zero since it's an integer now.

+1 with that fixed.

> Change Datanode file IO profiling sampling to percentage
> --------------------------------------------------------
>
>                 Key: HDFS-11722
>                 URL: https://issues.apache.org/jira/browse/HDFS-11722
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>         Attachments: HDFS-11722.001.patch
>
>
> Datanode disk IO profiling sampling is controlled by the setting _dfs.datanode.fileio.profiling.sampling.fraction_.
Instead of fraction, we can a percentage value to make it easier to set.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message