hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Weiwei Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11716) Ozone: SCM: CLI: Revisit delete container API
Date Mon, 08 May 2017 08:19:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000421#comment-16000421

Weiwei Yang commented on HDFS-11716:

Attached v1 patch, addressed following problems

# Removes container mapping in scm after container is successfully removed on datanodes. So
the container state is consistent before and after the delete operation.
# Fixed the issue that commented [here|https://issues.apache.org/jira/browse/HDFS-11716?focusedCommentId=15990152&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15990152]
after discussed with [~yuanbo] offline. We need this check no matter with or without force
# Added some more test cases in {{TestSCMCli}} to improve the coverage, including : a) Verify
if container exists in scm context; b) Verify create-delete-create manner, it should succeed;
c) Add a test to test deletion of a non-exist container.
#  Minor : refactor code in {{TestSCMCli}} to reuse some variable names.

[~anu], please kindly review.

> Ozone: SCM: CLI: Revisit delete container API
> ---------------------------------------------
>                 Key: HDFS-11716
>                 URL: https://issues.apache.org/jira/browse/HDFS-11716
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>         Attachments: HDFS-11716-HDFS-7240.001.patch
> Current delete container API seems can be possibly running into inconsistent state. SCM
maintains a mapping of container to nodes, datanode maintains the actual container's data.
When deletes a container, we need to make sure db is removed as well as the mapping in SCM
also gets updated. What if the datanode failed to remove stuff for a container, do we update
the mapping? We need to revisit the implementation and get these issues addressed. See more
discussion [here|https://issues.apache.org/jira/browse/HDFS-11675?focusedCommentId=15987798&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15987798].

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message