hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11709) StandbyCheckpointer should handle an non-existing legacyOivImageDir gracefully
Date Wed, 03 May 2017 02:01:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994163#comment-15994163
] 

Hudson commented on HDFS-11709:
-------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11677 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/11677/])
HDFS-11717. Add unit test for HDFS-11709 StandbyCheckpointer should (shv: rev d9014bda93760f223789d2ec9f5e35f40de157d4)
* (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyCheckpointer.java
* (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyCheckpoints.java


> StandbyCheckpointer should handle an non-existing legacyOivImageDir gracefully
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-11709
>                 URL: https://issues.apache.org/jira/browse/HDFS-11709
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: ha, namenode
>    Affects Versions: 2.6.1
>            Reporter: Zhe Zhang
>            Assignee: Erik Krogen
>            Priority: Critical
>             Fix For: 2.9.0, 2.7.4, 3.0.0-alpha3, 2.8.1
>
>         Attachments: HDFS-11709.000.patch
>
>
> In {{StandbyCheckpointer}}, if the legacy OIV directory is not properly created, or was
deleted for some reason (e.g. mis-operation), all checkpoint ops will fall. Not only the ANN
won't receive new fsimages, the JNs will get full with edit log files, and cause NN to crash.
> {code}
>       // Save the legacy OIV image, if the output dir is defined.
>       String outputDir = checkpointConf.getLegacyOivImageDir();
>       if (outputDir != null && !outputDir.isEmpty()) {
>         img.saveLegacyOIVImage(namesystem, outputDir, canceler);
>       }
> {code}
> It doesn't make sense to let such an unimportant part (saving OIV) abort all checkpoints
and cause NN crash (and possibly lose data).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message