hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11695) [SPS]: Namenode failed to start while loading SPS xAttrs from the edits log.
Date Wed, 17 May 2017 14:42:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014132#comment-16014132
] 

Uma Maheswara Rao G commented on HDFS-11695:
--------------------------------------------

Thanks [~surendrasingh] for the patch update. Patch mostly looks good.
I have one last comment to address:
{code}
+      FSDirSatisfyStoragePolicyOp.removeSPSXattr(this, inode, spsXAttr);
+      getEditLog().logSync();
     }
{code}
I noticed that you have added logSync in fsDirectory. For other APIs we are controlling logSync
from FSNameSystem layer only. So, to avoid breaking that pattern, how about we add a new API
in Namesystem#removeXattr(long id, String xattrName) ? this implementation can be in FSNameSystem
and have fslock and logsync.  So, while loading fsImage/Editlog we can still use FSDirectroy
unprotected api. But when cleaning Xattrs while system up for business functionality, we can
use Namesystem#removeXattr. I mean when you clean Xattr from SPS class, you can use Namesystem
method. 

> [SPS]: Namenode failed to start while loading SPS xAttrs from the edits log.
> ----------------------------------------------------------------------------
>
>                 Key: HDFS-11695
>                 URL: https://issues.apache.org/jira/browse/HDFS-11695
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS-10285
>            Reporter: Surendra Singh Lilhore
>            Assignee: Surendra Singh Lilhore
>            Priority: Blocker
>         Attachments: fsimage.xml, HDFS-11695-HDFS-10285.001.patch, HDFS-11695-HDFS-10285.002.patch,
HDFS-11695-HDFS-10285.003.patch, HDFS-11695-HDFS-10285.004.patch
>
>
> {noformat}
> 2017-04-23 13:27:51,971 ERROR org.apache.hadoop.hdfs.server.namenode.NameNode: Failed
to start namenode.
> java.io.IOException: Cannot request to call satisfy storage policy on path /ssl, as this
file/dir was already called for satisfying storage policy.
>         at org.apache.hadoop.hdfs.server.namenode.FSDirAttrOp.unprotectedSatisfyStoragePolicy(FSDirAttrOp.java:511)
>         at org.apache.hadoop.hdfs.server.namenode.FSDirXAttrOp.unprotectedSetXAttrs(FSDirXAttrOp.java:284)
>         at org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.applyEditLogOp(FSEditLogLoader.java:918)
>         at org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.loadEditRecords(FSEditLogLoader.java:241)
>         at org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.loadFSEdits(FSEditLogLoader.java:150)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message